Re: [PATCH] perf tools: Remove unused is_executable_file

From: Arnaldo Carvalho de Melo
Date: Mon Dec 23 2024 - 11:41:19 EST


On Mon, Dec 23, 2024 at 01:33:41PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Dec 23, 2024 at 01:32:15PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Sun, Dec 22, 2024 at 09:58:31PM +0000, linux@xxxxxxxxxxx wrote:
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>

> > > is_executable_file() has been unused since 2022's
> > > commit 7391db645938 ("perf test: Refactor shell tests allowing subdirs")

> > > Remove it.

> > Did you patch this on:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-tools-next

> > ?

> > That function is still there, so I'll fixup your patch, keep your
> > credits and test it all.
>
> FYI, it fails on the .h file:

I also added Carsten to the CC list, since he is the author of the
mentioned commit where that function stopped being used.

- Arnaldo