[PATCH v2] usb: gadget: m66592-udc: Add check for clk_enable()
From: Mingwei Zheng
Date: Wed Dec 25 2024 - 20:30:16 EST
The APP-Miner reported the missing check.
Add check for the return value of clk_enable() to catch the potential
error.
Fixes: b4822e2317e8 ("usb: gadget: m66592-udc: Convert to use module_platform_driver()")
Signed-off-by: Mingwei Zheng <zmw12306@xxxxxxxxx>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@xxxxxxxxx>
---
Changelog:
v1 -> v2
1. Add tool name in commit msg.
---
drivers/usb/gadget/udc/m66592-udc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c
index a938b2af0944..bf408476a24c 100644
--- a/drivers/usb/gadget/udc/m66592-udc.c
+++ b/drivers/usb/gadget/udc/m66592-udc.c
@@ -1606,7 +1606,11 @@ static int m66592_probe(struct platform_device *pdev)
ret = PTR_ERR(m66592->clk);
goto clean_up2;
}
- clk_enable(m66592->clk);
+ ret = clk_enable(m66592->clk);
+ if (ret) {
+ clk_put(m66592->clk);
+ goto clean_up2;
+ }
}
INIT_LIST_HEAD(&m66592->gadget.ep_list);
--
2.34.1