[PATCH v2] USB: phy: tahvo: Add check for clk_enable()

From: Mingwei Zheng
Date: Wed Dec 25 2024 - 20:32:24 EST


The APP-Miner reported the missing check.
Add check for the return value of clk_enable() to catch the potential
error.

Fixes: 9ba96ae5074c ("usb: omap1: Tahvo USB transceiver driver")
Signed-off-by: Mingwei Zheng <zmw12306@xxxxxxxxx>
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@xxxxxxxxx>
---
Changelog:

v1 -> v2

1. Add tool name in commit msg.
---
drivers/usb/phy/phy-tahvo.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index ae7bf3ff89ee..0b8801318cd2 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -342,8 +342,11 @@ static int tahvo_usb_probe(struct platform_device *pdev)
mutex_init(&tu->serialize);

tu->ick = devm_clk_get(&pdev->dev, "usb_l4_ick");
- if (!IS_ERR(tu->ick))
- clk_enable(tu->ick);
+ if (!IS_ERR(tu->ick)) {
+ ret = clk_enable(tu->ick);
+ if (ret)
+ return ret;
+ }

/*
* Set initial state, so that we generate kevents only on state changes.
--
2.34.1