Re: [External Mail] [RFC PATCH] mm/mempolicy: Weighted interleave auto-tuning

From: Gregory Price
Date: Fri Dec 27 2024 - 10:36:07 EST


On Fri, Dec 27, 2024 at 09:59:30AM +0800, Huang, Ying wrote:
> Gregory Price <gourry@xxxxxxxxxx> writes:
> > This still allows 0 to be a manual "reset specific node to default"
> > mechanism for a specific node, and gives us a clean override.
>
> The difficulty is that users don't know the default value when they
> reset a node's weight. We don't have an interface to show them. So, I
> suggest to disable the functionality: "reset specific node to default".
> They can still use "echo 1 > use_defaults" to reset all nodes to
> default.
>

Good point, and agree. So lets just ditch 0. Since that "feature"
wasn't even functional in the current code (it just reset it to 1 at
this point), it's probably safe to just ditch it. Worst case scenario
if someone takes issues, we can just have it revert the weight to 1.

~Gregory