Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but not used"

[Andi Shyti]

Hi Carlos,

On Sat, Dec 28, 2024 at 09:53:22PM +0100, Andi Shyti wrote:
> On Sat, Dec 28, 2024 at 05:08:52PM +0800, Carlos Song wrote:
> > lpi2c_resume_noirq() and lpi2c_suspend_noirq() are defined but it maybe
> > unused, so should add __maybe_unused to both functions to avoid build
> > warning.
> > 
> > Fixes: fa89723f7a78 ("i2c: imx-lpi2c: add target mode support")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202412280835.LRAV3z0g-lkp@xxxxxxxxx/
> > Signed-off-by: Carlos Song <carlos.song@xxxxxxx>
> 
> yeah, I have different PM configuration to catch these kind of
> error and I missed this.
> 
> Rather than applying a fix over a recent patch, I am going to
> remove your original patch and ask you to send a v7 of your
> "imx-lpi2c: add target mode support".
> 
> Is it OK with you?

I removed the patch and updated patchwork. I will be waiting for
your v7.

Thanks,
Andi