Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but not used"

[Carlos Song]

> -----Original Message-----
> From: Andi Shyti <andi.shyti@xxxxxxxxxx>
> Sent: Sunday, December 29, 2024 5:01 AM
> To: Carlos Song <carlos.song@xxxxxxx>
> Cc: Frank Li <frank.li@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel test
> robot <lkp@xxxxxxxxx>
> Subject: [EXT] Re: [PATCH] i2c: imx-lpi2c: fix build warning "function defined but
> not used"
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
> 
> 
> Hi Carlos,
> 
> On Sat, Dec 28, 2024 at 09:53:22PM +0100, Andi Shyti wrote:
> > On Sat, Dec 28, 2024 at 05:08:52PM +0800, Carlos Song wrote:
> > > lpi2c_resume_noirq() and lpi2c_suspend_noirq() are defined but it
> > > maybe unused, so should add __maybe_unused to both functions to
> > > avoid build warning.
> > >
> > > Fixes: fa89723f7a78 ("i2c: imx-lpi2c: add target mode support")
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > Closes:
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flo
> > > re.kernel.org%2Foe-kbuild-all%2F202412280835.LRAV3z0g-lkp%40intel.co
> > >
> m%2F&data=05%7C02%7Ccarlos.song%40nxp.com%7C20350a7984e64a96359
> d08dd
> > >
> 2782c95b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638710164
> 87754
> > >
> 0710%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjA
> uMDA
> > >
> wMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C
> &s
> > >
> data=FR4jUHXmRZxQOnaBRkMsYV5toDEhfAsWatxTfoizbjo%3D&reserved=0
> > > Signed-off-by: Carlos Song <carlos.song@xxxxxxx>
> >
> > yeah, I have different PM configuration to catch these kind of error
> > and I missed this.
> >
> > Rather than applying a fix over a recent patch, I am going to remove
> > your original patch and ask you to send a v7 of your
> > "imx-lpi2c: add target mode support".
> >
> > Is it OK with you?
> 
> I removed the patch and updated patchwork. I will be waiting for your v7.
> 
Hi, Andi, thank you very much! It helps a lot.:)

I will merge the fix to "imx-lpi2c: add target mode support" at V7 patch.

BR
Carlos Song

> Thanks,
> Andi