Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion

From: Donet Tom
Date: Sun Dec 29 2024 - 10:01:28 EST



On 12/27/24 21:26, Gregory Price wrote:
On Fri, Dec 27, 2024 at 04:31:48PM +0530, Donet Tom wrote:
folio_clear_referenced(folio);
workingset_activation(folio);
+ } else {
+
In the current implementation, promotion will not work if we enable MGLRU,
right?
Is there any specific reason we are not enabling promotion with MGLRU?

folio_mark_accessed may not be the best place to interpose for MGLRU,
since MGLRU's semantics are so different. I didn't want to dive that
deep until I could show traditional LRU benefit.

Certainly open to ideas if you're familiar with MGLRU semantics.
Thanks. I will take a look at it.

~Gregory