Re: [PATCH] riscv: Access time mmio instead of rdtime.

[Conor Dooley]

On Fri, Dec 27, 2024 at 04:00:56PM +0100, Aleksandar Rikalo wrote:
> +#if defined(CONFIG_RISCV_TIME_MMIO)
> +	if (!of_property_read_u64(n, "clock-reg", &mmio_addr)) {

This is a non-standard, undocumented property. reg & reg-names are what
you should be using here.

Cheers,
Conor.

> +		riscv_time_val = ioremap((long)mmio_addr, 8);
> +		if (riscv_time_val) {
> +			pr_info("Using mmio time register at 0x%llx\n", mmio_addr);
> +			static_branch_enable(&riscv_time_mmio_available);
> +		} else {
> +			pr_warn("Unable to use mmio time at 0x%llx\n", mmio_addr);
> +		}
> +	}
> +#endif

Attachment: signature.asc
Description: PGP signature