Re: [PATCH 2/6] genksyms: fix memory leak when the same symbol is read from *.symref file

From: Markus Elfring
Date: Fri Jan 03 2025 - 07:50:22 EST



> +++ b/scripts/genksyms/parse.y
> @@ -482,12 +482,12 @@ enumerator_list:
> enumerator:
> IDENT
> {
> - const char *name = strdup((*$1)->string);
> + const char *name = (*$1)->string;
> add_symbol(name, SYM_ENUM_CONST, NULL, 0);
> }


I would find it safer and cleaner to separate such adjustments into another update step.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc5#n81

Will code transformation concerns be reconsidered any more?

Regards,
Markus