Re: [PATCH v18 02/19] EDAC: Add scrub control feature
From: Borislav Petkov
Date: Mon Jan 06 2025 - 11:00:20 EST
On Mon, Jan 06, 2025 at 12:09:58PM +0000, shiju.jose@xxxxxxxxxx wrote:
> diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
> index f9cf19d8d13d..a162726cc6b9 100644
> --- a/drivers/edac/Makefile
> +++ b/drivers/edac/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_EDAC) := edac_core.o
>
> edac_core-y := edac_mc.o edac_device.o edac_mc_sysfs.o
> edac_core-y += edac_module.o edac_device_sysfs.o wq.o
> +edac_core-y += scrub.o
You're not being serious here - this scrub gunk is enabled by default on
*everything*?
So the main user of this is going to be CXL, AFAICT, so the scrubbing gunk
should depend at least on it or so. Definitely not unconditionally enabled on
every build.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette