Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support
From: Bastien Nocera
Date: Thu Jan 09 2025 - 08:40:23 EST
On Sun, 2025-01-05 at 11:16 +0100, Christian Mayer wrote:
>
> > On Wed, 2025-01-01 at 15:11 +0000, Christian Mayer wrote:
<snip>
> >
> > > + if (sd->quirks & STEELSERIES_ARCTIS_9) {
> > > + ret = hid_hw_open(hdev);
> >
> > Is this needed? If so, this probably needs to be added as a
> > separate
> > commit, for all headsets rather than just this one.
> Yes that's mandatory to get raw_events from the device.
> I thought about adding this to all headsets, but i was not sure if
> this
> breaks anything for the Arctis 1 headset.
>
> But i can add this for all headsets, that's fine with me.
> Would you like me to create a completely separate patch for this or
> should i submit this with the preparation patch which refactors
> steelseries_headset_fetch_battery?
Please send a patch that does it for both headsets, and I'll test it
locally.