Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support

From: Christian Mayer
Date: Sun Jan 12 2025 - 06:49:32 EST




Am 09.01.25 um 14:35 schrieb Bastien Nocera:
On Sun, 2025-01-05 at 11:16 +0100, Christian Mayer wrote:

On Wed, 2025-01-01 at 15:11 +0000, Christian Mayer wrote:
<snip>
+ if (sd->quirks & STEELSERIES_ARCTIS_9) {
+ ret = hid_hw_open(hdev);

Is this needed? If so, this probably needs to be added as a
separate
commit, for all headsets rather than just this one.
Yes that's mandatory to get raw_events from the device.
I thought about adding this to all headsets, but i was not sure if
this
breaks anything for the Arctis 1 headset.

But i can add this for all headsets, that's fine with me.
Would you like me to create a completely separate patch for this or
should i submit this with the preparation patch which refactors
steelseries_headset_fetch_battery?

Please send a patch that does it for both headsets, and I'll test it
locally.
I resent the patches with the requested changes (v2)
Please use v2-0001-HID-steelseries-preparation-for-adding-SteelSerie.patch for testing.