Re: [PATCH v1] perf symbol-elf: Avoid a weak cxx_demangle_sym function

[Arnaldo Carvalho de Melo]

On Thu, Jan 09, 2025 at 09:58:34AM -0800, Ian Rogers wrote:
> On Mon, Nov 18, 2024 at 7:17 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > cxx_demangle_sym is weak in case demangle-cxx.c replaces the
> > definition in symbol-elf.c. When demangle-cxx.c is built
> > HAVE_CXA_DEMANGLE_SUPPORT is defined, as such the define can be used
> > to avoid a weak symbol. As weak symbols are outside of the C standard
> > their use can lead to strange behaviors, in particular with LTO, as
> > well as causing issues to be hidden at link time.
> >
> > Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> 
> Ping.

Thanks, applied to perf-tools-next,

- Arnaldo