Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages
From: Andrew Morton
Date: Fri Jan 10 2025 - 20:45:49 EST
On Fri, 10 Jan 2025 09:14:47 +0100 David Hildenbrand <david@xxxxxxxxxx> wrote:
> > To migrate huge 0, we obtain huge x from the pool. After the migration
> > is completed, we return the now-freed huge 0 back to the pool. When
> > it's time to migrate huge 1, we can simply reuse the now-freed huge 0
> > from the pool. As a result, when replace_free_hugepage_folios() is
> > executed, it cannot release huge 0 back to the buddy system.
> >
> > To slove the proble above, we should prevent reuse of isolated free
> > hugepages.
>
> s/slove/solve/
> s/proble/problem/
>
> >
> > Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@xxxxxxx/
> > Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration")
>
> The commit id is not stable yet.
>
> $ git tag --contains 08d312ee4c0a
> mm-everything-2025-01-09-06-44
> next-20250110
>
>
> We should squash this into the original fix. Can you resend the whole
> thing and merge the patch descriptions?
I queued this as
replace-free-hugepage-folios-after-migration-fix-3.patch. But yes, a
clean v4 with a redone changelog would be a nice thing to have.