Re: [PATCH v4 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property

From: Peter Korsgaard
Date: Sat Jan 11 2025 - 13:24:30 EST


>>>>> "Guenter" == Guenter Roeck <linux@xxxxxxxxxxxx> writes:

Hi,

>> Guenter, what do you say? This way we don't need any new device tree
>> properties. I personally find it less clear than a default-pwm property,
>> but oh well.
>>

> I would not call that "default". It is more along the line of
> "If available, use highest cooling level as maximum allowed".

Sorry, what are you referring to exactly? The commit message? The change
is about the default/initial pwm setting, there is nothing disallowing
user space to increase it afterwards?


> Other than that, I don't like it, but since it looks like we
> won't get approval for the devicetree property, I'd say go for it.

Great, then we agree! I'll send a v5 then once it is clear what your
comment above refers to.

--
Bye, Peter Korsgaard