Re: [PATCH v4 1/2] dt-bindings: hwmon: pwm-fan: Document default-pwm property

From: Guenter Roeck
Date: Sat Jan 11 2025 - 17:45:26 EST


On 1/11/25 10:24, Peter Korsgaard wrote:
"Guenter" == Guenter Roeck <linux@xxxxxxxxxxxx> writes:

Hi,

>> Guenter, what do you say? This way we don't need any new device tree
>> properties. I personally find it less clear than a default-pwm property,
>> but oh well.
>>

> I would not call that "default". It is more along the line of
> "If available, use highest cooling level as maximum allowed".

Sorry, what are you referring to exactly? The commit message? The change
is about the default/initial pwm setting, there is nothing disallowing
user space to increase it afterwards?


From the current probe function:

"Set duty cycle to maximum allowed". If you dislike the term "maximum allowed",
please consider something like "Set initial duty cycle to maximum or, if provided,
to the highest cooling level".

Guenter