Re: [PATCH v2 1/6] dt-bindings: clock: imx8m: document nominal/overdrive properties

[Ahmad Fatoum]

Hi Krzysztof,
Hi Conor,

On 07.01.25 07:52, Krzysztof Kozlowski wrote:
> On Mon, Jan 06, 2025 at 08:55:08PM +0100, Ahmad Fatoum wrote:
>> I am not sure what's the preference is though, should we have>>
>>   fsl,operating-mode = "normal" / "overdrive"
>>
>> or 
>>
>>   fsl,operating-mode = <IMX_OPMODE_NORMAL> / <IMX_OPMODE_OVERDRIVE>
>>
>>
>> Any idea? Conor?
> 
> If these are two exclusive modes (plus default), then as Frank
> suggested: use enum of strings. Imagine encoding enum of 10 values with
> bools as you did: that would be enourmous oneOf condition or if:then:.
> 
> Preferred is strings, but numerical values are also accepted.

Ok, I went with strings for v3. Thanks

@Conor, as the binding changed I've dropped your Ack from v3.

Thanks,
Ahmad

> 
> Best regards,
> Krzysztof
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |