Re: [PATCH v2 1/6] dt-bindings: clock: imx8m: document nominal/overdrive properties

From: Ahmad Fatoum
Date: Mon Jan 13 2025 - 08:53:19 EST


Hi Frank,

On 06.01.25 20:42, Frank Li wrote:
> On Mon, Jan 06, 2025 at 08:25:38PM +0100, Ahmad Fatoum wrote:
>> [1]: https://lore.kernel.org/all/4e2250b3-5170-4e88-aa0a-dd796b81e78b@xxxxxxxxxxxxxx/
>>
>
> But there are problem if use dts overlay because dts overlay can't support
> delete property.
>
> If one dts file use "fsl,overdrive-mode", dts overlay file can't delete
> this property. "mutually exclusive optional properties" was not preferred.
>
> mode = ["normal" | "overdrive"]

I just sent out v3[1] with your suggestion incorporated, but missed adding
you to Cc.

[1]: https://lore.kernel.org/all/20250113-imx8m-clk-v3-0-0d6e9bdeaa4e@xxxxxxxxxxxxxx/

Thanks,
Ahmad

>
> Frank
>
>> Thanks,
>> Ahmad
>>
>>
>>>
>>> Frank
>>>
>>>> required:
>>>> - compatible
>>>> - reg
>>>> @@ -95,6 +103,12 @@ allOf:
>>>> - const: clk_ext2
>>>> - const: clk_ext3
>>>> - const: clk_ext4
>>>> + - if:
>>>> + required:
>>>> + - fsl,overdrive-mode
>>>> + then:
>>>> + properties:
>>>> + fsl,nominal-mode: false
>>>>
>>>> additionalProperties: false
>>>>
>>>>
>>>> --
>>>> 2.39.5
>>>>
>>>
>>
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>


--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |