Re: [PATCH] memory: omap-gpmc: Use of_property_present() for non-boolean properties

From: Rob Herring
Date: Mon Jan 13 2025 - 09:08:28 EST


On Fri, Jan 10, 2025 at 3:08 AM Roger Quadros <rogerq@xxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On 09/01/2025 20:21, Rob Herring (Arm) wrote:
> > The use of of_property_read_bool() for non-boolean properties is
> > deprecated in favor of of_property_present() when testing for property
> > presence.
> >
> > While we're here, simplify the 2 checks into a single check as they
> > only differ in printing "NAND" vs "OneNAND" in the warning.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > ---
> > Possibly this check could just be removed altogether?
>
> Yes, I agree it is better to just drop these checks.
> Let me know if you want me to prepare the path. Thanks.

Please do. You would know better than me on the details of why it
would be fine to remove.

Rob