Re: [RESEND PATCH v2] riscv: cacheinfo: Use of_property_present() for non-boolean properties

From: Geert Uytterhoeven
Date: Tue Jan 14 2025 - 05:52:54 EST


Hi Rob,

Thanks for your patch!

On Tue, Dec 31, 2024 at 5:14 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.

Please add

This gets rid of the following boot warnings:

OF: /cpus/cpu@0: Read of boolean property 'i-cache-size' with a value.
OF: /cpus/cpu@0: Read of boolean property 'd-cache-size' with a value.
OF: /soc/cache-controller@13400000: Read of boolean property
'cache-size' with a value.

so the next person doesn't have to dive into the code to find this patch ;-)

> Reviewed-by: Clément Léger <cleger@xxxxxxxxxxxx>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds