Re: [RESEND PATCH v2] riscv: cacheinfo: Use of_property_present() for non-boolean properties
From: Rob Herring
Date: Tue Jan 14 2025 - 10:26:28 EST
On Tue, Jan 14, 2025 at 4:52 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> Thanks for your patch!
>
> On Tue, Dec 31, 2024 at 5:14 PM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> > The use of of_property_read_bool() for non-boolean properties is
> > deprecated in favor of of_property_present() when testing for property
> > presence.
>
> Please add
>
> This gets rid of the following boot warnings:
>
> OF: /cpus/cpu@0: Read of boolean property 'i-cache-size' with a value.
> OF: /cpus/cpu@0: Read of boolean property 'd-cache-size' with a value.
> OF: /soc/cache-controller@13400000: Read of boolean property
> 'cache-size' with a value.
>
> so the next person doesn't have to dive into the code to find this patch ;-)
If this patch had been picked up in a timely manner, no one would have
ever seen that warning. I'll leave it to the riscv maintainers to add
that if they desire. That warning didn't exist when this patch was
written.
Rob