Re: [PATCH v6] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

[Steven Rostedt]

On Wed, 15 Jan 2025 10:33:39 +0100
Lukas Wunner <lukas@xxxxxxxxx> wrote:

> > > 
> > > 	TP_STRUCT__entry(
> > > 		__string(	port_name,	pci_name(ctrl->pcie->port)	)
> > > 		__string(	slot,		slot_name(ctrl)			)
> > > 		__field(	int,		event				)
> > > 
> > > and everything else could be the same.  
> > 
> > Maybe it's not a good idea.
> > 
> > I think pci_hp_event is a generic event for pciehp, shpchp, octep_hp, etc.
> > But each hotplug driver has different `struct controller` and slot_name().  
> [...]
> > So, IMHO, pass port_name and slot_name from each driver is more simple.
> > 
> > + @Lukas for hotplug part.  
> 
> You're right Shuai, there's several hotplug drivers in drivers/pci/hotplug/
> and pciehp is just one of them.  It's quite possible that other drivers
> besides pciehp will want to add trace points as well.  For consistency,
> the trace event definitions need to work for all drivers.

OK, if this is a generic trace event then it does make sense sending in the
names instead of the structure.

-- Steve