Re: [PATCH v2] mm: separate move/undo parts from migrate_pages_batch()
From: Zi Yan
Date: Wed Jan 15 2025 - 10:06:06 EST
On 15 Jan 2025, at 5:34, Byungchul Park wrote:
> Changes from v1
> - Fix a wrong coding style
>
> --->8---
> From a65a6e4975962707bf87171e317f005c6276887e Mon Sep 17 00:00:00 2001
> From: Byungchul Park <byungchul@xxxxxx>
> Date: Thu, 8 Aug 2024 15:53:58 +0900
> Subject: [PATCH v2] mm: separate move/undo parts from migrate_pages_batch()
>
> Functionally, no change. This is a preparation for luf mechanism that
> requires to use separated folio lists for its own handling during
> migration. Refactored migrate_pages_batch() so as to separate move/undo
> parts from migrate_pages_batch().
>
> Signed-off-by: Byungchul Park <byungchul@xxxxxx>
> Reviewed-by: Shivank Garg <shivankg@xxxxxxx>
> ---
> mm/migrate.c | 134 +++++++++++++++++++++++++++++++--------------------
> 1 file changed, 83 insertions(+), 51 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
I am planning to send the batching page copy part in my page migration
acceleration patchset separately for upstream first, so that we can
focus on the page copy acceleration, using multithreads and DMA
afterwards.
Best Regards,
Yan, Zi