RE: [PATCH] platform/mellanox: mlxreg-hotplug: use sysfs_emit() instead of sprintf()

[Vadim Pasternak]

> -----Original Message-----
> From: Ai Chao <aichao@xxxxxxxxxx>
> Sent: Thursday, 16 January 2025 10:10
> To: hdegoede@xxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx; Vadim Pasternak
> <vadimp@xxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Ai Chao <aichao@xxxxxxxxxx>
> Subject: [PATCH] platform/mellanox: mlxreg-hotplug: use sysfs_emit() instead
> of sprintf()
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: Ai Chao <aichao@xxxxxxxxxx>

Acked-by: Vadim Pasternak <vadimp@xxxxxxxxxx>

> ---
>  drivers/platform/mellanox/mlxreg-hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c
> b/drivers/platform/mellanox/mlxreg-hotplug.c
> index 6aa2a4650367..b347000e4329 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -232,7 +232,7 @@ static ssize_t mlxreg_hotplug_attr_show(struct device
> *dev,
>  			regval = !!(regval & data->mask);
>  	}
> 
> -	return sprintf(buf, "%u\n", regval);
> +	return sysfs_emit(buf, "%u\n", regval);
>  }
> 
>  #define PRIV_ATTR(i) priv->mlxreg_hotplug_attr[i]
> --
> 2.47.1