RE: [PATCH] platform/mellanox: mlxreg-io: use sysfs_emit() instead of sprintf()

[Vadim Pasternak]

> -----Original Message-----
> From: Ai Chao <aichao@xxxxxxxxxx>
> Sent: Thursday, 16 January 2025 10:11
> To: hdegoede@xxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx; Vadim Pasternak
> <vadimp@xxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Cc: Ai Chao <aichao@xxxxxxxxxx>
> Subject: [PATCH] platform/mellanox: mlxreg-io: use sysfs_emit() instead of
> sprintf()
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: Ai Chao <aichao@xxxxxxxxxx>

Acked-by: Vadim Pasternak <vadimp@xxxxxxxxxx>

> ---
>  drivers/platform/mellanox/mlxreg-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-io.c
> b/drivers/platform/mellanox/mlxreg-io.c
> index 595276206baf..97fefe6c38d1 100644
> --- a/drivers/platform/mellanox/mlxreg-io.c
> +++ b/drivers/platform/mellanox/mlxreg-io.c
> @@ -126,7 +126,7 @@ mlxreg_io_attr_show(struct device *dev, struct
> device_attribute *attr,
> 
>  	mutex_unlock(&priv->io_lock);
> 
> -	return sprintf(buf, "%u\n", regval);
> +	return sysfs_emit(buf, "%u\n", regval);
> 
>  access_error:
>  	mutex_unlock(&priv->io_lock);
> --
> 2.47.1