Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

[Krzysztof Kozlowski]

On 16/01/2025 02:21, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@xxxxxxxxxxxx>
> 
> This patch adds TR(token ring) manipulations and adds correct
> macro names for those magic numbers. TR is a way to access
> proprietary registers on page 52b5. Use these helper functions
> so we can see which fields we're going to modify/set/clear.
> 
> This patch doesn't really change registers' settings but just
> enhances readability and maintainability.
> 
> Signed-off-by: SkyLake.Huang <skylake.huang@xxxxxxxxxxxx>
Few days ago I complained the Mediatek too frequent uses login as full
name. Several different Mediatek contributors repeat the same mistake,
so I asked to fix this internally with some sort of
guideline/checklist/internal reviews.

Other patches here look OK, so there is some progress, but not complete
- please fix here as well.

Best regards,
Krzysztof