Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

[Andrew Lunn]

> +/* ch_addr = 0x1, node_addr = 0xf, data_addr = 0x1 */
> +/* MrvlTrFix100Kp */
> +#define MRVL_TR_FIX_100KP_MASK			GENMASK(22, 20)
> +/* MrvlTrFix100Kf */
> +#define MRVL_TR_FIX_100KF_MASK			GENMASK(19, 17)
> +/* MrvlTrFix1000Kp */
> +#define MRVL_TR_FIX_1000KP_MASK			GENMASK(16, 14)
> +/* MrvlTrFix1000Kf */
> +#define MRVL_TR_FIX_1000KF_MASK			GENMASK(13, 11)

What does the Mrvl prefix stand for?

This patch is pretty much impossible to review because it makes so
many changes. Please split it up into lots of small simple changes.

    Andrew

---
pw-bot: cr