Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence

[Jakub Kicinski]

On Thu, 16 Jan 2025 16:26:18 +0100 Larysa Zaremba wrote:
> > +	for (q = 0; q < oct->num_ioq_stats; q++) {
> > +		tx_packets += oct->stats_iq[q].instr_completed;
> > +		tx_bytes += oct->stats_iq[q].bytes_sent;
> > +		rx_packets += oct->stats_oq[q].packets;
> > +		rx_bytes += oct->stats_oq[q].bytes;  
> 
> Correct me if I am wrong, but the interface-wide statistics should not change 
> when changing queue number. In such case maybe it would be a good idea to 
> always iterate over all OCTEP_MAX_QUEUES queues when calculating the stats.

Good catch!
-- 
pw-bot: cr