RE: [EXTERNAL] Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats locally for persistence

[Shinas Rasheed]

Hi Jakub, Larysa

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Friday, January 17, 2025 5:57 AM
> To: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
> Cc: Shinas Rasheed <srasheed@xxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Haseeb Gani <hgani@xxxxxxxxxxx>; Sathesh B Edara
> <sedara@xxxxxxxxxxx>; Vimlesh Kumar <vimleshk@xxxxxxxxxxx>;
> thaller@xxxxxxxxxx; wizhao@xxxxxxxxxx; kheib@xxxxxxxxxx;
> konguyen@xxxxxxxxxx; horms@xxxxxxxxxx; einstein.xue@xxxxxxxxxx;
> Veerasenareddy Burru <vburru@xxxxxxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>
> Subject: [EXTERNAL] Re: [PATCH net v8 2/4] octeon_ep: update tx/rx stats
> locally for persistence
> 
> On Thu, 16 Jan 2025 16:26:18 +0100 Larysa Zaremba wrote:
> > > +	for (q = 0; q < oct->num_ioq_stats; q++) {
> > > +		tx_packets += oct->stats_iq[q].instr_completed;
> > > +		tx_bytes += oct->stats_iq[q].bytes_sent;
> > > +		rx_packets += oct->stats_oq[q].packets;
> > > +		rx_bytes += oct->stats_oq[q].bytes;
> >
> > Correct me if I am wrong, but the interface-wide statistics should not change
> > when changing queue number. In such case maybe it would be a good idea
> to
> > always iterate over all OCTEP_MAX_QUEUES queues when calculating the
> stats.
> 
> Good catch!

The queues which are iterated over here refer to the hardware queues, and it is in fact iterating over all the queues.
Can you please clarify more?

Thanks

> --
> pw-bot: cr