Re: [PATCH] iommu/arm-smmu-v3: Include string_choices.h header for str_read_write
From: Pranjal Shrivastava
Date: Fri Jan 17 2025 - 03:34:35 EST
On Thu, Jan 16, 2025 at 01:10:25PM +0100, AngeloGioacchino Del Regno wrote:
> The str_read_write() helper function is defined in the missing
> string_choices.h header: include it to resolve build failures.
>
> Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> index 0e4cbb2c64d7..a0e395da8a88 100644
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -26,6 +26,7 @@
> #include <linux/pci.h>
> #include <linux/pci-ats.h>
> #include <linux/platform_device.h>
> +#include <linux/string_choices.h>
> #include <kunit/visibility.h>
> #include <uapi/linux/iommufd.h>
>
Hi Angelo,
This change has been applied to the arm/smmu/updates branch and should
be available in the -next when the maintainers rebuild the branch.
Thanks,
Praan