Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug

From: Vincent Guittot
Date: Fri Jan 17 2025 - 03:33:02 EST


On Fri, 17 Jan 2025 at 03:23, zihan zhou <15645113830zzh@xxxxxxxxx> wrote:
>
> In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable
> tasks" table, but not all tasks in the table are runnable.
> It is inappropriate to refer to this table as "runnable tasks", so here it
> is changed to "Tasks on CPU %d", like:

We have used replaced runnable by queued in fair scheduler

>
> Tasks on cpu 31:
> S task PID vruntime eligible deadline
> --------------------------------------------------------------------
> S cpuhp/31 173 0.803286 E 2.153245
> S migration/31 174 8.167468 E 11.167468
>
> PS For the sake of clarity in reality, some table information has been
> omitted here.
>
>
> Signed-off-by: zihan zhou <15645113830zzh@xxxxxxxxx>
> Signed-off-by: yaozhenguo <yaozhenguo@xxxxxx>
> Signed-off-by: yaowenchao1 <yaowenchao@xxxxxx>
> ---
> kernel/sched/debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index a1be00a988bf..687487128400 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -771,7 +771,7 @@ static void print_rq(struct seq_file *m, struct rq *rq, int rq_cpu)
> struct task_struct *g, *p;
>
> SEQ_printf(m, "\n");
> - SEQ_printf(m, "runnable tasks:\n");
> + SEQ_printf(m, "Tasks on cpu %d:\n", rq_cpu);
> SEQ_printf(m, " S task PID vruntime eligible "
> "deadline slice sum-exec switches "
> "prio wait-time sum-sleep sum-block"
> --
> 2.33.0
>