Re: [PATCH V1] sched/debug: change "runnable tasks" to "Tasks on cpu" on sched debug

From: Peter Zijlstra
Date: Fri Jan 17 2025 - 06:38:34 EST


On Fri, Jan 17, 2025 at 09:32:43AM +0100, Vincent Guittot wrote:
> On Fri, 17 Jan 2025 at 03:23, zihan zhou <15645113830zzh@xxxxxxxxx> wrote:
> >
> > In sched debug file /sys/kernel/debug/sched/debug, there is a "runnable
> > tasks" table, but not all tasks in the table are runnable.
> > It is inappropriate to refer to this table as "runnable tasks", so here it
> > is changed to "Tasks on CPU %d", like:
>
> We have used replaced runnable by queued in fair scheduler

Right, but also 'tasks on cpu' is equally wrong -- but really, if you're
looking at sched/debug you have to know what you're doing anyway, so why
bother with trivial stuff like this?

> > Tasks on cpu 31:
> > S task PID vruntime eligible deadline
> > --------------------------------------------------------------------
> > S cpuhp/31 173 0.803286 E 2.153245
> > S migration/31 174 8.167468 E 11.167468
> >
> > PS For the sake of clarity in reality, some table information has been
> > omitted here.
> >
> >
> > Signed-off-by: zihan zhou <15645113830zzh@xxxxxxxxx>
> > Signed-off-by: yaozhenguo <yaozhenguo@xxxxxx>
> > Signed-off-by: yaowenchao1 <yaowenchao@xxxxxx>

And that's a broken SoB chain.