Re: [PATCH v15 6/7] input: max77693: add max77705 haptic support

[Dzmitry Sankouski]

пт, 17 янв. 2025 г. в 11:02, Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>
> On 17/01/2025 09:01, Krzysztof Kozlowski wrote:
> >
> >>      case TYPE_MAX77843:
> >>              haptic->regmap_haptic = max77693->regmap;
> >>              break;
> >> @@ -407,6 +418,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(max77693_haptic_pm_ops,
> >>
> >>  static const struct platform_device_id max77693_haptic_id[] = {
> >>      { "max77693-haptic", },
> >> +    { "max77705-haptic", },
> >>      { "max77843-haptic", },
>
>
> ... and also drop this change, since compatible is going away and we
> expect matching by OF.
>
> >>      {},
> >>  };
> >> @@ -414,6 +426,7 @@ MODULE_DEVICE_TABLE(platform, max77693_haptic_id);
> >>
> >>  static const struct of_device_id of_max77693_haptic_dt_match[] = {
> >>      { .compatible = "maxim,max77693-haptic", },
> >> +    { .compatible = "maxim,max77705-haptic", },
> >
> > So the device looks fully compatible with max77693. Drop this change and
> > express compatibility with fallback.

Cannot be done, because config_reg is different.

-- 
Best regards and thanks for review,
Dzmitry