Re: [RFC v3 01/18] dt-bindings: clock: Add VO subsystem clock controller support
From: Krzysztof Kozlowski
Date: Wed Jan 22 2025 - 02:44:32 EST
On 21/01/2025 22:29, Michal Wilczynski wrote:
>
>
> On 1/21/25 10:47, Krzysztof Kozlowski wrote:
>> On Mon, Jan 20, 2025 at 06:20:54PM +0100, Michal Wilczynski wrote:
>>> properties:
>>> compatible:
>>> - const: thead,th1520-clk-ap
>>> + enum:
>>> + - thead,th1520-clk-ap
>>> + - thead,th1520-clk-vo
>>>
>>> reg:
>>> maxItems: 1
>>>
>>> clocks:
>>> items:
>>> - - description: main oscillator (24MHz)
>>> + - description: main oscillator (24MHz) or CLK_VIDEO_PLL
>>
>> thead,th1520-clk-ap gets also VIDEO_PLL? Aren't both serving the same
>> purpose from these devices point of view? Bindings are telling what this
>> device is expecting.
>
> Since thead,th1520-clk-ap configures PLL clocks it takes the oscillator
> 24MHz as an input, so no.
>
> The VO subsystem takes as an input VIDEO_PLL that's configured by the
> AP.
I understood that, but you really did not answer to my question. How is
the input called? Not how is the clock called.
>
> I could do something like this if this needs to be formally expressed in
> the schema:
It is enough to put it in description.
Best regards,
Krzysztof