Re: [PATCH] staging: gpib: Make static and reduce forward declarations

[Dan Carpenter]

On Wed, Jan 22, 2025 at 10:37:33AM +0300, Dan Carpenter wrote:
> On Tue, Jan 21, 2025 at 09:33:42PM +0100, Dave Penkler wrote:
> > Declaring the entry points as static caused a warning that the
> > serial_poll_status function of the agilent_82350b driver was
> > unused.
> > 
> > Add the entry point to the corresponding interface structure
> > initializations where it was missing.
> 
> ...
> 
> > @@ -842,6 +824,7 @@ static gpib_interface_t agilent_82350b_unaccel_interface = {
> >  	.primary_address = agilent_82350b_primary_address,
> >  	.secondary_address = agilent_82350b_secondary_address,
> >  	.serial_poll_response = agilent_82350b_serial_poll_response,
> > +	.serial_poll_status = agilent_82350b_serial_poll_status,
> >  	.t1_delay = agilent_82350b_t1_delay,
> >  	.return_to_local = agilent_82350b_return_to_local,
> >  };
> > @@ -869,12 +852,12 @@ static gpib_interface_t agilent_82350b_interface = {
> >  	.primary_address = agilent_82350b_primary_address,
> >  	.secondary_address = agilent_82350b_secondary_address,
> >  	.serial_poll_response = agilent_82350b_serial_poll_response,
> > +	.serial_poll_status = agilent_82350b_serial_poll_status,
> >  	.t1_delay = agilent_82350b_t1_delay,
> >  	.return_to_local = agilent_82350b_return_to_local,
> >  };
> 
> So what happened is that Sparse was complaining and you were cleaning
> up the code and you discovered this bug.  Fine.  But bug fixes need to
> be in their own commit, not hidden inside a giant cleanup patch.  They
> need to have a commit message.

s/commit message/Fixes tag/...

regards,
dan carpenter