Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes
From: Nishanth Menon
Date: Fri Jan 24 2025 - 17:08:48 EST
On 13:16-20250124, Rob Herring wrote:
> Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> "syscon" compatible") broke drivers which call device_node_to_regmap()
> on nodes without a "syscon" compatible. Restore the prior behavior for
> device_node_to_regmap().
>
> This also makes using device_node_to_regmap() incompatible with
> of_syscon_register_regmap() again, so add kerneldoc for
> device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> how and when each one should be used.
>
> Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> Cc: Will McVicker <willmcvicker@xxxxxxxxxx>
> Cc: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> Reported-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
Thanks Rob.
Tested with next-20250124 on TI K3 platforms
Tested-by: Nishanth Menon <nm@xxxxxx>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D