Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes

From: Nícolas F. R. A. Prado
Date: Tue Jan 28 2025 - 17:54:14 EST


On Fri, Jan 24, 2025 at 01:16:44PM -0600, Rob Herring (Arm) wrote:
> Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> "syscon" compatible") broke drivers which call device_node_to_regmap()
> on nodes without a "syscon" compatible. Restore the prior behavior for
> device_node_to_regmap().
>
> This also makes using device_node_to_regmap() incompatible with
> of_syscon_register_regmap() again, so add kerneldoc for
> device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> how and when each one should be used.
>
> Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> Cc: Will McVicker <willmcvicker@xxxxxxxxxx>
> Cc: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> Reported-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Still hitting this as of next-20250128. This patch fixed the issue which
otherwise prevents boot on the Genio 700 EVK and Genio 1200 EVK boards.

Tested-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Thanks,
Nícolas