Re: [PATCH RFC WIP v2] rust: add bitfield_options macro to create bitfield wrapper types

[Timothy Garwood]

> What I think is actually missing is an another patch integrating this or
> showing usage of this somewhere, for example in samples/drivers.

I did just that here: [1]
Link: https://lore.kernel.org/rust-for-linux/20250128-add-bitfield-options-macro-v2-1-d65349b389fc@xxxxxxxxxxxxxx [1]

Maybe I should have made a second patch in this series instead of a new 
series but since this usage example depends on the HrTimer patch series I
thought it best to separate. I am new here though, so I may very well be 
wrong about that.
[1] depended on this v2 so I could not reference it in the v2, I think. I
will reference it in the v3.


> Missing period at the end.
Will fix, thanks.

> Capitalization of the first word.

Will fix thanks.

> This might be opinionated, but it may be better to use positional
> parameters [1] as it is not that noisy to read in the source code.

I have no opinion on this, I'll make the change for readability.

> > +///```rust
> The rust is implicit.

I'll remove them all then.

Thank you Daniel,
Timothy