Re: [RFC PATCH 0/2] Introduce configfs-based interface for gpio-aggregator

[Bartosz Golaszewski]

On Thu, Jan 30, 2025 at 5:04 PM Koichiro Den <koichiro.den@xxxxxxxxxxxxx> wrote:
>
> On Thu, Jan 30, 2025 at 11:30:59AM GMT, Bartosz Golaszewski wrote:
> >
> > 3. I don't think the user should need to specify the number of lines
> > to aggregate. That information should be automatically inferred from
> > the number of lineX attributes they created instead. [...]
>
> I agree that it's essentially unnecessary, but considering the current
> state of gpio-sim's configfs, having the user set num_lines doesn't seem
> too unnatural to me. What do you think?
>

No, this is completely different. We cannot figure out how many lines
the user wants gpio-sim to have without explicitly providing that
information over the num_lines attribute. For the aggregator, we know
exactly how many lines the user wants - it's determined by the number
of line groups. We can simply wait for the live attribute to be set to
1 and then count them. While at it: there's no reason to impose a
naming convention of lineX, lineY etc., the names don't matter for the
aggregator setup (unlike gpio-sim where they indicate the offset of
the line they concern).

Bart