Re: [PATCH] m68k: sun3: Use str_read_write() helper in mmu_emu_handle_fault()

[Thorsten Blum]

On 20. Jan 2025, at 16:41, Geert Uytterhoeven wrote:
>> --- a/arch/m68k/sun3/mmu_emu.c
>> +++ b/arch/m68k/sun3/mmu_emu.c
>> @@ -371,7 +372,7 @@ int mmu_emu_handle_fault (unsigned long vaddr, int read_flag, int kernel_fault)
>> 
>> #ifdef DEBUG_MMU_EMU
>>        pr_info("%s: vaddr=%lx type=%s crp=%p\n", __func__, vaddr,
>> -               read_flag ? "read" : "write", crp);
>> +               str_read_write(read_flag), crp);
> 
> You haven't really tested this with DEBUG_MMU_EMU enabled, have you?
> Fix sent.

Sorry, I missed this question.

I compile-tested it with DEBUG_MMU_EMU, but ignored the pr_info() error
you fixed in [1].

Thanks,
Thorsten

[1] https://lore.kernel.org/linux-kernel/b1d12a1d24b4aea9f98d905383ba932b2dc382e6.1737387419.git.geert@xxxxxxxxxxxxxx/