Re: [PATCH v1 02/12] iio: accel: adxl345: reorganize measurement enable

[Jonathan Cameron]

On Tue, 28 Jan 2025 12:00:50 +0000
Lothar Rubusch <l.rubusch@xxxxxxxxx> wrote:

> In order to have this function generically available a position at the
> top makes more sense. In upcomming patches for particular features the
> function needs to be available, to turn off measuring while changing
> settings, and turn it on again afterwards.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@xxxxxxxxx>
> ---
>  drivers/iio/accel/adxl345_core.c | 54 ++++++++++++++++----------------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
> index ffdb03ed7a25..142f12117627 100644
> --- a/drivers/iio/accel/adxl345_core.c
> +++ b/drivers/iio/accel/adxl345_core.c
> @@ -163,6 +163,33 @@ static const unsigned long adxl345_scan_masks[] = {
>  	0
>  };
>  
> +/**
> + * adxl345_set_measure_en() - Enable and disable measuring.
> + *
> + * @st: The device data.
> + * @en: Enable measurements, else standby mode.
> + *
> + * For lowest power operation, standby mode can be used. In standby mode,
> + * current consumption is supposed to be reduced to 0.1uA (typical). In this
> + * mode no measurements are made. Placing the device into standby mode
> + * preserves the contents of FIFO.
> + *
> + * Return: Returns 0 if successful, or a negative error value.
> + */
> +static int adxl345_set_measure_en(struct adxl345_state *st, bool en)
> +{
> +	unsigned int val = en ? ADXL345_POWER_CTL_MEASURE : ADXL345_POWER_CTL_STANDBY;
> +
> +	return regmap_write(st->regmap, ADXL345_REG_POWER_CTL, val);
> +}
> +
> +static void adxl345_powerdown(void *ptr)
> +{
> +	struct adxl345_state *st = ptr;
> +
> +	adxl345_set_measure_en(st, false);
> +}
Why move powerdown?  This looks to be a devm callback, if that's all it used for
leave that down near wherever it is used.
Moving set_measure_en makes sense, just not this user of it.

> +
>  static int adxl345_set_interrupts(struct adxl345_state *st)
>  {
>  	int ret;
> @@ -301,33 +328,6 @@ static int adxl345_write_raw_get_fmt(struct iio_dev *indio_dev,
>  	}
>  }
>  
> -/**
> - * adxl345_set_measure_en() - Enable and disable measuring.
> - *
> - * @st: The device data.
> - * @en: Enable measurements, else standby mode.
> - *
> - * For lowest power operation, standby mode can be used. In standby mode,
> - * current consumption is supposed to be reduced to 0.1uA (typical). In this
> - * mode no measurements are made. Placing the device into standby mode
> - * preserves the contents of FIFO.
> - *
> - * Return: Returns 0 if successful, or a negative error value.
> - */
> -static int adxl345_set_measure_en(struct adxl345_state *st, bool en)
> -{
> -	unsigned int val = en ? ADXL345_POWER_CTL_MEASURE : ADXL345_POWER_CTL_STANDBY;
> -
> -	return regmap_write(st->regmap, ADXL345_REG_POWER_CTL, val);
> -}
> -
> -static void adxl345_powerdown(void *ptr)
> -{
> -	struct adxl345_state *st = ptr;
> -
> -	adxl345_set_measure_en(st, false);
> -}
> -
>  static IIO_CONST_ATTR_SAMP_FREQ_AVAIL(
>  "0.09765625 0.1953125 0.390625 0.78125 1.5625 3.125 6.25 12.5 25 50 100 200 400 800 1600 3200"
>  );