Re: [PATCH v2 1/4] perf trace: Allocate syscall stats only if summary is on

[Ian Rogers]

On Wed, Jan 29, 2025 at 7:05 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> The syscall stats are used only when summary is requested.  Let's avoid
> unnecessary operations.  Pass 'trace' pointer to check summary and give
> output file together.

I don't think this last sentence makes sense.

Thanks,
Ian

> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
>  tools/perf/builtin-trace.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index ac97632f13dc8f7c..7e0324a2e9182088 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1522,13 +1522,14 @@ struct thread_trace {
>         struct intlist *syscall_stats;
>  };
>
> -static struct thread_trace *thread_trace__new(void)
> +static struct thread_trace *thread_trace__new(struct trace *trace)
>  {
>         struct thread_trace *ttrace =  zalloc(sizeof(struct thread_trace));
>
>         if (ttrace) {
>                 ttrace->files.max = -1;
> -               ttrace->syscall_stats = intlist__new(NULL);
> +               if (trace->summary)
> +                       ttrace->syscall_stats = intlist__new(NULL);
>         }
>
>         return ttrace;
> @@ -1550,7 +1551,7 @@ static void thread_trace__delete(void *pttrace)
>         free(ttrace);
>  }
>
> -static struct thread_trace *thread__trace(struct thread *thread, FILE *fp)
> +static struct thread_trace *thread__trace(struct thread *thread, struct trace *trace)
>  {
>         struct thread_trace *ttrace;
>
> @@ -1558,7 +1559,7 @@ static struct thread_trace *thread__trace(struct thread *thread, FILE *fp)
>                 goto fail;
>
>         if (thread__priv(thread) == NULL)
> -               thread__set_priv(thread, thread_trace__new());
> +               thread__set_priv(thread, thread_trace__new(trace));
>
>         if (thread__priv(thread) == NULL)
>                 goto fail;
> @@ -1568,7 +1569,7 @@ static struct thread_trace *thread__trace(struct thread *thread, FILE *fp)
>
>         return ttrace;
>  fail:
> -       color_fprintf(fp, PERF_COLOR_RED,
> +       color_fprintf(trace->output, PERF_COLOR_RED,
>                       "WARNING: not enough memory, dropping samples!\n");
>         return NULL;
>  }
> @@ -2622,7 +2623,7 @@ static int trace__sys_enter(struct trace *trace, struct evsel *evsel,
>                 return -1;
>
>         thread = machine__findnew_thread(trace->host, sample->pid, sample->tid);
> -       ttrace = thread__trace(thread, trace->output);
> +       ttrace = thread__trace(thread, trace);
>         if (ttrace == NULL)
>                 goto out_put;
>
> @@ -2699,7 +2700,7 @@ static int trace__fprintf_sys_enter(struct trace *trace, struct evsel *evsel,
>                 return -1;
>
>         thread = machine__findnew_thread(trace->host, sample->pid, sample->tid);
> -       ttrace = thread__trace(thread, trace->output);
> +       ttrace = thread__trace(thread, trace);
>         /*
>          * We need to get ttrace just to make sure it is there when syscall__scnprintf_args()
>          * and the rest of the beautifiers accessing it via struct syscall_arg touches it.
> @@ -2771,7 +2772,7 @@ static int trace__sys_exit(struct trace *trace, struct evsel *evsel,
>                 return -1;
>
>         thread = machine__findnew_thread(trace->host, sample->pid, sample->tid);
> -       ttrace = thread__trace(thread, trace->output);
> +       ttrace = thread__trace(thread, trace);
>         if (ttrace == NULL)
>                 goto out_put;
>
> @@ -2960,7 +2961,7 @@ static int trace__sched_stat_runtime(struct trace *trace, struct evsel *evsel,
>         struct thread *thread = machine__findnew_thread(trace->host,
>                                                         sample->pid,
>                                                         sample->tid);
> -       struct thread_trace *ttrace = thread__trace(thread, trace->output);
> +       struct thread_trace *ttrace = thread__trace(thread, trace);
>
>         if (ttrace == NULL)
>                 goto out_dump;
> @@ -3214,7 +3215,7 @@ static int trace__pgfault(struct trace *trace,
>                 }
>         }
>
> -       ttrace = thread__trace(thread, trace->output);
> +       ttrace = thread__trace(thread, trace);
>         if (ttrace == NULL)
>                 goto out_put;
>
> --
> 2.48.1.262.g85cc9f2d1e-goog
>