Re: [PATCH v2 1/4] perf trace: Allocate syscall stats only if summary is on
From: Namhyung Kim
Date: Mon Feb 03 2025 - 21:59:14 EST
On Sat, Feb 01, 2025 at 10:57:00PM -0800, Ian Rogers wrote:
> On Wed, Jan 29, 2025 at 7:05 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > The syscall stats are used only when summary is requested. Let's avoid
> > unnecessary operations. Pass 'trace' pointer to check summary and give
> > output file together.
>
> I don't think this last sentence makes sense.
Thanks for your review. I'd say: Pass 'trace' pointer instead of doing
'summary' option and 'output' file pointer separately.
Thanks,
Namhyung