Re: [PATCH 1/7] firmware: cs_dsp: Fix error checking in wseq_write()

From: Markus Elfring
Date: Sun Feb 02 2025 - 12:34:19 EST


> cs_dsp_coeff_write_ctrl() may return a non-zero value (1)
> upon success. Change error checking in the write sequencer
> code such that it checks for negative errnos rather than
> any non-zero value when using this function.

* Please improve the change description.
https://elixir.bootlin.com/linux/v6.13.1/source/drivers/firmware/cirrus/cs_dsp.c#L786

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?


Regards,
Markus