Re: [PATCH v3 02/11] sched_ext: Add an event, SCX_EV_SELECT_CPU_FALLBACK

From: Tejun Heo
Date: Sun Feb 02 2025 - 12:34:54 EST


On Fri, Jan 31, 2025 at 04:09:29PM +0900, Changwoo Min wrote:
...
> @@ -2170,6 +2175,11 @@ static void enqueue_task_scx(struct rq *rq, struct task_struct *p, int enq_flags
> do_enqueue_task(rq, p, enq_flags, sticky_cpu);
> out:
> rq->scx.flags &= ~SCX_RQ_IN_WAKEUP;
> +
> + if ((enq_flags & SCX_ENQ_CPU_SELECTED) &&
> + (cpu_of(rq) != p->scx.selected_cpu)) {
> + __scx_add_event(SCX_EV_SELECT_CPU_FALLBACK, 1);
> + }
> }

I made minor edits to the above block while applying:

if ((enq_flags & SCX_ENQ_CPU_SELECTED) &&
unlikely(cpu_of(rq) != p->scx.selected_cpu))
__scx_add_event(SCX_EV_SELECT_CPU_FALLBACK, 1);

Thanks.

--
tejun