Re: [PATCH v7 0/9] DTS updates for system1 BMC

[Andrew Jeffery]

Hi Ninad,

On Mon, 2025-02-03 at 08:44 -0600, Ninad Palsule wrote:
> Hello,
> 
> Please review the patch set version 7.
> 
> V7:
> ---
>   - Updated pattern in the ast2400-gpio.yaml
>   - Dropped "dt-bindings: net: faraday,ftgmac100" patch sending it
>     separately.
> 
> V6:
> ---
>   - Fixed dt_binding_check errors for ipmb-dev.yaml
>   - Changed the hog parsing pattern in ast2400-gpio
> 
> V5:
> ---
>   - Improved IPBM device documentation.
>   - Added the hog parsing in ast2400-gpio
> 
> V4:
> ---
>   - Removed "Add RGMII support" patch as it needs some work from the
>     driver side.
>   - Improved IPBM device documentation.
>   - There is a new warning in CHECK_DTBS which are false positive so
>     ignored them.
>     arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb:
> gpio@1e780000: 'hog-0', 'hog-1', 'hog-2', 'hog-3' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> 
> V3:
> ---
>   - Fixed dt_binding_check warnings in ipmb-dev.yaml
>   - Updated title and description in ipmb-dev.yaml file.
>   - Updated i2c-protocol description in ipmb-dev.yaml file.
> 
> V2:
> ---
>   Fixed CHECK_DTBS errors by
>     - Using generic node names
>     - Documenting phy-mode rgmii-rxid in ftgmac100.yaml
>     - Adding binding documentation for IPMB device interface
> 
> NINAD PALSULE (6):

Why is your name all in caps here but not for the binding patches
below? Can you fix that up?

>   ARM: dts: aspeed: system1: Add IPMB device
>   ARM: dts: aspeed: system1: Add GPIO line name
>   ARM: dts: aspeed: system1: Reduce sgpio speed
>   ARM: dts: aspeed: system1: Update LED gpio name
>   ARM: dts: aspeed: system1: Remove VRs max8952
>   ARM: dts: aspeed: system1: Mark GPIO line high/low
> 
> Ninad Palsule (3):
>   bindings: ipmi: Add binding for IPMB device intf

This one needs an ack from Corey if I'm to take it.

>   dt-bindings: gpio: ast2400-gpio: Add hogs parsing

This one needs an ack from Linus W or Bartosz if I'm to take it.
However, it's also causing some grief from Rob's bot:

https://lore.kernel.org/all/173859694889.2601726.10618336219726193824.robh@xxxxxxxxxx/

As the reported nodes should all be hogs the name shouldn't matter
anywhere else (as far as I'm aware). It would be nice if all the
warnings were cleaned up before we merged the binding update. That way
we don't cause everyone else looking at the CHECK_DTBS=y output more
grief than they already get for the Aspeed devicetrees.

In order to not get bogged down it might be worth splitting out both
the IPMB- and GPIO- related patches like you did the FTGMAC100 patch,
and then I can merge what remains (from a quick look they seem
relatively uncontroversial).

Andrew

>   ARM: dts: aspeed: system1: Disable gpio pull down
> 
>  .../bindings/gpio/aspeed,ast2400-gpio.yaml    |   6 +
>  .../devicetree/bindings/ipmi/ipmb-dev.yaml    |  56 +++++++
>  .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 139 +++++++++++-----
> --
>  3 files changed, 147 insertions(+), 54 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/ipmi/ipmb-
> dev.yaml
>