Re: [PATCH v7 0/9] DTS updates for system1 BMC

[Ninad Palsule]

Hi Andrew,

Thank you for the review.

> > NINAD PALSULE (6):
>
> Why is your name all in caps here but not for the binding patches
> below? Can you fix that up?

Fixed in the version 9


> > Ninad Palsule (3):
> >    bindings: ipmi: Add binding for IPMB device intf
>
> This one needs an ack from Corey if I'm to take it.
>
> >    dt-bindings: gpio: ast2400-gpio: Add hogs parsing
>
> This one needs an ack from Linus W or Bartosz if I'm to take it.
> However, it's also causing some grief from Rob's bot:
>
> https://lore.kernel.org/all/173859694889.2601726.10618336219726193824.robh@xxxxxxxxxx/
>
> As the reported nodes should all be hogs the name shouldn't matter
> anywhere else (as far as I'm aware). It would be nice if all the
> warnings were cleaned up before we merged the binding update. That way
> we don't cause everyone else looking at the CHECK_DTBS=y output more
> grief than they already get for the Aspeed devicetrees.
>
> In order to not get bogged down it might be worth splitting out both
> the IPMB- and GPIO- related patches like you did the FTGMAC100 patch,
> and then I can merge what remains (from a quick look they seem
> relatively uncontroversial).

The warnings are fixed by different patch by Krzysztof. As there are no 
more changes then I will wait for other responses. If I don't get those 
response in couple of days then I will split it.
https://lore.kernel.org/linux-kernel/20250116085947.87241-1-krzysztof.kozlowski@xxxxxxxxxx/

I am also planning to fix old warnings in the system1 dts in separate patch.


--
Thanks & Regards,
Ninad