Re: [GIT PULL] kthreads fixes for v6.14-rc2

From: Frederic Weisbecker
Date: Tue Feb 04 2025 - 16:44:09 EST


Le Tue, Feb 04, 2025 at 11:06:57AM -0800, Linus Torvalds a écrit :
> On Tue, 4 Feb 2025 at 10:58, Frederic Weisbecker <frederic@xxxxxxxxxx> wrote:
> >
> > - Properly handle return value when allocation fails for the preferred
> > affinity.
>
> Well, we have exactly one caller of this function, and that caller
> doesn't actually care about the return value.
>
> The function is literally the "preferred" affinity. If the affinity
> setup fails, it's harmless.
>
> Anyway, the fix doesn't look wrong, and I've pulled it, but it's just
> all very harmless. I think the "set but not used" error could have
> been fixed by just removing the 'ret' variable entirely.

Right, I wanted to be able to reflect failure just in case but the
point of doing it is certainly debatable... Thanks for pulling it
anyway!