Re: [GIT PULL] kthreads fixes for v6.14-rc2

[Dhruva Gole]

On Feb 04, 2025 at 11:06:57 -0800, Linus Torvalds wrote:
> On Tue, 4 Feb 2025 at 10:58, Frederic Weisbecker <frederic@xxxxxxxxxx> wrote:
> >
> > - Properly handle return value when allocation fails for the preferred
> >   affinity.
> 
> Well, we have exactly one caller of this function, and that caller
> doesn't actually care about the return value.

Yeah that was my initial thought while sending the fix here:
https://lore.kernel.org/linux-kernel/20250204090838.214647-1-d-gole@xxxxxx/

This patch hasn't appeared in next yet (next-20250204) so I missed this thread.

> 
> The function is literally the "preferred" affinity. If the affinity
> setup fails, it's harmless.
> 
> Anyway, the fix doesn't look wrong, and I've pulled it, but it's just
> all very harmless. I think the "set but not used" error could have
> been fixed by just removing the 'ret' variable entirely.
> 
>                 Linus
> 

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated