max8997 cleanup bug?
From: Dr. David Alan Gilbert
Date: Tue Feb 04 2025 - 19:32:55 EST
Hi Lee,
I noticed that:
drivers/mfd/max8997-irq.c max8997_irq_exit
isn't called anywhere and was about to send a deadcode patch,
but I'm thinking it's actually a bug and it should be called.
Looking at the max8998, it has basically the same function,
and it calls it from an error path in it's max8998_i2c_probe.
There's no equivalent call in max8997's probe.
To me it looks like it probably goes after the 'err_i2c_haptic:'
label, but I don't know the code and as far as I know I don't
have one of the devices.
Any thoughts?
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/